Closed tbirdso closed 3 years ago
Note dependency error is expected while itk-shape
PyPi package is pending:
# Verify ITKShape dependency assert(hasattr(itk, 'MeshProcrustesAlignFilter')) E AssertionError
Note that we're seeing different behavior across platforms; Python CI on Ubuntu observes a higher final registration convergence metric than on macOS or Windows (local test).
~One thought is that this could have to do with itk::PyVectorContainer
wrapping? KdTree
requires a PyVectorContainer
object for reading out nearest-neighbor results. PyVectorContainer
is wrapped for itk.UL
or itk.ULL
key/values depending on available VectorContainer
wrappings by platform, previously observed different wrappings for Ubuntu/Windows tests with Github CI although no behavioral differences otherwise until now.~
Linux testing issue resolved as an issue with getting/setting Vnl vectors as an attempt to copy by reference, workaround instead copies by value. Issue in question is copying points from itk.Mesh
to itk.ListSample
with a single pass-through so not expected to make a significant performance difference.
Added itk-shape
dependency from PyPi and squashed fixup commits.
Changes in this PR:
ninja
package dependency from Python CIDepends on ITKShape PyPi packaging.
Closes #51.