search

KitwareMedical / SlicerVirtualReality

A Slicer extension that enables user to interact with a Slicer scene using virtual reality.
Apache License 2.0
117 stars 58 forks source link

SlicerVirtualReality extension has build errors with latest Slicer-5.3 version #118

Closed lassoan closed 1 year ago

lassoan commented 1 year ago

Since the last VTK update SlicerVirtualReality fails to build:

https://slicer.cdash.org/viewBuildError.php?buildid=3085845

D:\D\P\S-0-E-b\SlicerVirtualReality\VirtualReality\MRML\vtkVirtualRealityViewInteractor.h(49,16): error C3668: 'vtkVirtualRealityViewInteractor::HandleGripEvents': method with override specifier 'override' did not override any base class methods [D:\D\P\S-0-E-b\SlicerVirtualReality-build\inner-build\VirtualReality\MRML\vtkSlicerVirtualRealityModuleMRML.vcxproj] [D:\D\P\S-0-E-b\SlicerVirtualReality-build\inner.vcxproj]

jcfr commented 1 year ago

Regression has been identified.

It turns that the version of MR-9892 that was originally backported into Slicer/VTK was updated to use more explicit function names. For example HandleComplexGestureEvents instead of HandleGripEvents.

See https://gitlab.kitware.com/vtk/vtk/-/merge_requests/9892/diffs#98a6a752aa28f44d961d072a1bf5ff10724f0218

I proposed a pull request addressing the issue later in the afternoon.