Get package working on OSX.

KitwareMedical / VTKPythonPackage

A setup script to generate VTK Python Wheels

https://vtkpythonpackage.readthedocs.io

BSD 3-Clause "New" or "Revised" License

34 stars 15 forks source link

Get package working on OSX. #12

Closed prabhuramachandran closed 6 years ago

prabhuramachandran commented 6 years ago

Added a simple build script in scripts/osx_build_wheels.py.
Also bumps up version to 8.1.0 since that is the latest public release.

@jcfr -- this seems to work well for me. Please let me know if you'd like me to make any changes. It would be great if this could be merged. It also includes a fix for issue #10.

prabhuramachandran commented 6 years ago

@jcfr -- if you are fine with what I have done, I can also send a PR after this one to document the build process on OS X. If you prefer of course I can add it to the present PR.

thewtex commented 6 years ago

@prabhuramachandran well done!!

To help the binaries work on older versions of macOS, set CMAKE_OSX_DEPLOYMENT_TARGET to 10.9 as demonstrated in ITKPythonPackage.

jcfr commented 6 years ago

@prabhuramachandran Please, if still needed consider rebasing the fix for #10 on top of https://github.com/jcfr/VTKPythonPackage/pull/14

jcfr commented 6 years ago

@prabhuramachandran Closing this PR. It is superseded by https://github.com/jcfr/VTKPythonPackage/pull/15

prabhuramachandran commented 6 years ago

@jcfr -- Thanks for the new PR, will take a look there.

prabhuramachandran commented 6 years ago

@thewtex -- thanks, I missed the OSX_DEPLOYMENT_TARGET.