search

KitwareMedical / VTKPythonPackage

A setup script to generate VTK Python Wheels
https://vtkpythonpackage.readthedocs.io
BSD 3-Clause "New" or "Revised" License
34 stars 15 forks source link

Error downloading source with VTK 8.1.0 on Linux #13

Open prabhuramachandran opened 6 years ago

prabhuramachandran commented 6 years ago

When I updated the version to 8.1.0 and try to run the build script on Linux, I get the following error:

$ ./scripts/dockcross-manylinux-build-wheels.sh 

[...]
[1/5] Performing update step for 'VTK-source-download'
FAILED: VTK-source-download-prefix/src/VTK-source-download-stamp/VTK-source-download-update 
cd /work/standalone-x64-build/VTK-source && /usr/bin/cmake -P /work/standalone-x64-build/VTK-source-download-prefix/tmp/VTK-source-download-gitupdate.cmake
From https://github.com/kitware/VTK
   dcf423b..c0f9780  master     -> origin/master
   dcf423b..ca2f34c  nightly-master -> origin/nightly-master
Previous HEAD position was 782d7ed... Merge commit '6610577d' into release
HEAD is now at ab71574... Merge topic 'deprecate-hot' into release
Submodule 'VTK-m' (https://gitlab.kitware.com/vtk/vtk-m.git) registered for path 'ThirdParty/vtkm/vtk-m'
Cloning into 'ThirdParty/vtkm/vtk-m'...
warning: protocol restrictions not applied to curl redirects because
your curl version is too old (>= 7.19.4)
error: Unknown SSL protocol error in connection to gitlab.kitware.com:443  while accessing https://gitlab.kitware.com/vtk/vtk-m.git/info/refs?service=git-upload-pack
fatal: HTTP request failed
Clone of 'https://gitlab.kitware.com/vtk/vtk-m.git' into submodule path 'ThirdParty/vtkm/vtk-m' failed
CMake Error at /work/standalone-x64-build/VTK-source-download-prefix/tmp/VTK-source-download-gitupdate.cmake:157 (message):
  Failed to update submodules in: '/work/standalone-x64-build/VTK-source/'

This doesn't seem right as the version of curl is recent enough. This seems like an intermittent error though and suddenly it seems to work again. Do you think it may be a good idea to build this without having to do a download each time, instead we could mount a local source directory and pass that into the script?

prabhuramachandran commented 6 years ago

Hmm, this is related to the horribly old version of git on the centos5 docker image. I am not sure what the best way to upgrade this is. I think it may be good to allow the user to point to a pre-existing source dir.

prabhuramachandran commented 6 years ago

Scratch that, since cwd is mounted as /work, I can work around the issue by doing a git clone in standalone-x64-build.

thewtex commented 6 years ago

@prabhuramachandran I think we fixed this with recent updates to the Docker image. @jcfr @fbudin69500 thoughts?

fbudin69500 commented 6 years ago

@thewtex Yes, the dockcross images have been updated to address the SSL issues. Both a recent version of curl and a recent version of Git are installed in the recent dockcross images. @prabhuramachandran Could you verify if your images are up to date? EDIT: More specifically this problem was updated in this commit. I do not know if the images that are available on dockerhub have been updated, but you can rebuild the images locally.

jcfr commented 6 years ago

available on dockerhub have been updated

Image was last updated 12 days ago. See https://hub.docker.com/r/dockcross/manylinux-x64/tags/