search

KitwareMedical / VTKPythonPackage

A setup script to generate VTK Python Wheels
https://vtkpythonpackage.readthedocs.io
BSD 3-Clause "New" or "Revised" License
34 stars 15 forks source link

Add macOS build script #15

Closed jcfr closed 6 years ago

jcfr commented 6 years ago

From @thewtex: To help the binaries work on older versions of macOS, set CMAKE_OSX_DEPLOYMENT_TARGET to 10.9 as demonstrated in ITKPythonPackage.

I can also send a PR after this one to document the build process on OS X

@prabhuramachandran Let's do this in a different PR after this one has been integrated.

Also note that the script was renamed from osx_build_wheels.py to macos_build_wheels.py

prabhuramachandran commented 6 years ago

@jcfr -- do I have push rights on this repo? Do you want me to make any specific changes or are you going to? Thanks for rebasing this on top of #14.

jcfr commented 6 years ago

are you advocating a similar approach with an empty file on Linux and OS X?

yes 👍

Shouldn't this be needed on Linux also?

It is already the case

https://github.com/jcfr/VTKPythonPackage/blob/962ae4f89ca9b0c5cd5c46bdd8fd63eb31cb57f2/scripts/internal/manylinux-build-common.sh#L33-L47

do I have push rights on this repo?

Yes. I just added you as a collaborator

Do you want me to make any specific changes or are you going to?

It would be great to implement something similar on macOS

prabhuramachandran commented 6 years ago

Perfect, thanks! I'll make the changes later this week. Spent too much midnight oil last few days.

prabhuramachandran commented 6 years ago

I've made the changes but am unable to push. Is there something special I should do to push, my remote looks like this:

upstream git@github.com:jcfr/VTKPythonPackage.git (fetch) upstream git@github.com:jcfr/VTKPythonPackage.git (push)

but it does not allow me to push

jcfr commented 6 years ago

It looks like you haven't accepted the invitation: https://github.com/jcfr/VTKPythonPackage/invitations

prabhuramachandran commented 6 years ago

Thanks! Never seemed to have needed that before.

prabhuramachandran commented 6 years ago

OK I've pushed the suggested changes, please let me know if there are any other things I need to check -- I am re-running a build to test this out and it is churning away which is a good thing.

jcfr commented 6 years ago

Nitpick: Since commit entitled "Make suggested fixes as per review." are not very informative, I would prefer you cherry pick the commit.

prabhuramachandran commented 6 years ago

OK I will send a more detailed commit message, is it OK if I do a force push to amend the commit?

jcfr commented 6 years ago

is it OK if I do a force push to amend the commit

👍

prabhuramachandran commented 6 years ago

Hope this one works.

prabhuramachandran commented 6 years ago

Now that this is merged, maybe I'll update the docs over the weekend, OK?

jcfr commented 6 years ago

maybe I'll update the docs over the weekend, OK?

That would be great 👍