Add tests using pytest - Githubissues

KitwareMedical / dicom-anonymizer

Tool to anonymize DICOM files according to the DICOM standard

BSD 3-Clause "New" or "Revised" License

104 stars 47 forks source link

Add tests using pytest #47

Closed sharayujosh closed 1 year ago

sharayujosh commented 1 year ago

Created initial infrastructure for unit testing using pytest.
Created functions to test deleted, changed, and emptied tags
Updated setup.cfg to require pytest for development
Updated README.md with information on how to test

Some of the pydicom test data files are failing anonymization checks. I have excluded them in the tests for now. So far, 104 files pass.

pchoisel commented 1 year ago

Hi @sharayujosh,

Thank you very much for this pull request, it was long due we added some tests to this project.
I did some comments, tell me what you think about them.

Thank you again, Paul

sharayujosh commented 1 year ago

Hi @sharayujosh,

Thank you very much for this pull request, it was long due we added some tests to this project. I did some comments, tell me what you think about them.

Thank you again, Paul

Thank you for the feedback, I am working on the suggested changes.

sharayujosh commented 1 year ago

The improvements you made are great, thanks ! I just made some minor formatting suggestions, then I think it will be good to merge

Thank you, I've made the suggested changes. I could not concatenate the lists using commas, so I used the plus operator instead.

pchoisel commented 1 year ago

Sorry, I forgot those were lists and not strings.

Thank you for your work !
If I have time, I'll try to make the tests run automatically on Github each time there is a new PR