KitwareMedical / dicom-anonymizer

Tool to anonymize DICOM files according to the DICOM standard
BSD 3-Clause "New" or "Revised" License
104 stars 47 forks source link

Strategy for Python version compatibility? #54

Closed smjoshiatglobus closed 10 months ago

smjoshiatglobus commented 1 year ago

I was trying this project on Python 3.12 and discovered that it has removed bundled setuptools and with it pkg_resources. This breaks the recent version information change. What is the right way to fix this? I see these paths:

I volunteer to make these changes, but need guidance!

The strategy question: what is your recommendation for maintaining compatibility with older versions of Python? It seems the new version of Pydicom will require at least 3.10 version of python.

jcfr commented 1 year ago

I suggest to remove setup.{py,cfg} and transition to pyproject.toml.

Relevant references:

smjoshiatglobus commented 1 year ago

I, too, would like to move to pyproject.toml. I can include that change when I add one of the three packages I mentioned above.

smjoshiatglobus commented 12 months ago

See PR #57

pchoisel commented 10 months ago

Closing this with the merge of #57