Proposal: Introduce ruff for code formatting and linting

KitwareMedical / dicom-anonymizer

Tool to anonymize DICOM files according to the DICOM standard

BSD 3-Clause "New" or "Revised" License

104 stars 47 forks source link

Proposal: Introduce ruff for code formatting and linting #75

Closed smasuda closed 4 months ago

smasuda commented 6 months ago

Hi!

I have started looking into the codes and have sent one PR, and noticed the current code base might be under some code formatter/linter other than ruff or black which are common these days.

How about introduce one of them like pydicom and make it as this project's default? Even today some contributors have changed single quote to double qoute to surround string, which isn't consistent.

pchoisel commented 6 months ago

Hi !

Indeed, a unified formatter would do us good. To make this decision followed, we should implement a pre-commit rule with https://pre-commit.com/ as well as a new pipeline step in the CI that executes Ruff.

I don't have the time to do it right now so feel free to open a PR for this, otherwise I'll do it in the following weeks

pchoisel commented 4 months ago

Fixed with #84