search

KivalM / spotblock-rs

A spotify advertisment muter for Pipewire
GNU General Public License v3.0
14 stars 3 forks source link

Fixed ad not being muted #7

Closed albarozzz closed 2 years ago

albarozzz commented 2 years ago

6

KivalM commented 2 years ago

Ideally, we would like this to keep working with all versions of the client. My fear is that the trackid change was isolated, so we would still encounter the old format some of the time.

If you can add this as a third condition to your PR rather than replacing the existing one, that would be great.

Something like response.starts_with("spotify:ad:") || response.starts_with("/com/spotify/ad/")||response.is_empty();

albarozzz commented 2 years ago

Done!

KivalM commented 2 years ago

Looks to be all good here. Thanks for contributing