Fix bug in aur.lua (old pkg present in builddir)

Kiwi / clyde

Next-generation libalpm/makepkg wrapper.

https://kiwi.github.io/clyde

Other

63 stars 8 forks source link

Fix bug in aur.lua (old pkg present in builddir) #98

Closed r-vdp closed 13 years ago

r-vdp commented 13 years ago

When upgrading aur packages a bug is triggered when an already built package is still in the builddir. This is due to giving only the filename instead of the whole path as input to pkg_ver in aur.lua.

I changed this behaviour and the bug appears to be solved.

Instructions to reproduce the original bug (prior to my patch):

build clyde-git
put an older package for clyde in the still-present builddir
rebuild clyde using "clyde -S clyde-git"

PS: It appears my editor changed some empty lines to comply with the majority of empty lines (it removed indentation on those lines) I hope this is ok.

Cheers.

juster commented 13 years ago

excellent! but I would rather make the change simpler. I was thinking of prefixing the directory when the path is appended to the pkgfiles table. Something like: table.insert( pkgfiles, pkgdir .. "/" .. file ).

The reason I decided to make by_version a function was to use it with table.sort

I don't mind the empty spaces being removed they are annoying. I should configure my editor the same. lua-mode for emacs is not terribly good.