Kixiron / lasso

A fast, concurrent string interner
Apache License 2.0
137 stars 20 forks source link

`serialize` feature doesn't compile even without any changes #50

Open Brogolem35 opened 3 weeks ago

Brogolem35 commented 3 weeks ago

I tried this code

Code:

pub struct MarkovChain {
    items: HashMap<Vec<Spur>, ChainItem>,
    state_size: usize,
    regex: Regex,
    cache: Rodeo,
}

Cargo.toml

[package]
name = "markov_str"
version = "0.1.0"
authors = ["brogolem35"]
edition = "2021"
description = "Markov Chain implementation optimized for text generation."
license = "MIT"
repository = "https://github.com/Brogolem35/markov_str"
keywords = ["markov", "markov-chain", "text-generation"]
categories = ["text-processing"]

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[features]
serialize = ["serde", "lasso/serialize", "hashbrown/serde"]

[dependencies]
hashbrown = "0.14.5"
lasso = {version = "0.7.2", features = ["ahasher", "inline-more"]}
rand = "0.8.5"
regex = "1.10.6"
serde = {version = "1.0.208", features = ["derive"], optional = true, default-features = false}

# [target.'cfg(not(target_env = "msvc"))'.dependencies]
# tikv-jemallocator = "0.6"

[package.metadata.clippy]
# This sets all pedantic lints to be treated as errors
deny = ["clippy::pedantic"]

I expected this to happen

Code should have compiled as there have been compile with no issues.

Instead this happened

Compilation fails even though I changed no code other than enabling the feature.

Meta

version = "0.7.2", features = ["ahasher", "inline-more"]

Rustc version:

> rustc -Vv
rustc 1.80.0 (051478957 2024-07-21)
binary: rustc
commit-hash: 051478957371ee0084a7c0913941d2a8c4757bb9
commit-date: 2024-07-21
host: x86_64-unknown-linux-gnu
release: 1.80.0
LLVM version: 18.1.7
Brogolem35 commented 3 weeks ago

The same happens with (as expected):

git clone https://github.com/Kixiron/lasso.git
cd lasso
git checkout v0.7.2 
cargo build --features=serialize

But this issue doesn't occure in latest commit even though I don't see any commit messages that adress this.