Kixunil / seven_segment

A simple Rust driver for 7-segment displays
4 stars 1 forks source link

Add support for dot #1

Closed wucke13 closed 4 years ago

wucke13 commented 4 years ago

Most seven segment displays come with an eighth segment, the dot. Please add support for that to this crate.

Kixunil commented 4 years ago

I considered this, but I concluded it's not actually needed, as the API would be the same as manually setting the pin outside of this crate. But maybe I'm missing something and there's something that'd make it simpler? In that case, I'm willing to reevaluate the idea.

wucke13 commented 4 years ago

That is a good point. I think this only makes sense if the API is extended by a way of controlling multiple SSDs. However I'm not convinced that that would be a good Idea.

Kixunil commented 4 years ago

Yeah, closing for now. One idea was to add a higher-level API capable of displaying decimal numbers, but I'd implement it in another crate as that is a concern of another layer.