search

Kixunil / tonic_lnd

Rust implementation of LND RPC client using async GRPC library `tonic`
31 stars 46 forks source link

Support wallet rpc #21

Closed DanGould closed 2 years ago

DanGould commented 2 years ago

This is a subset of @yzernik's #20 which introduces support for rpc::wallet as in lncli wallet. More like a 100 line change than 1800, plus the .proto files from lnd.

I propose a common Client since the generated LightningClient and WalletKitClient that represent lncli and lncli wallet respectively since take the same parameters.

Please give me feedback on the design of this common Client. Thanks ⚡️

DanGould commented 2 years ago

nice lesson in std::path

DanGould commented 2 years ago

Added changes at your request. Also updated the README.md to reflect these changes. Docs & examples already updated.

yzernik commented 2 years ago

I like the idea of having the Client struct with the inner fields for the separate APIs. I have added the same struct in the tonic_openssl_lnd fork: https://github.com/yzernik/tonic_openssl_lnd/pull/21

I am trying to keep my fork as close as possible to the upstream, with the only difference being that it uses openssl vs rustls.

DanGould commented 2 years ago

Gah! good catch. Should be done & doc'd with v0.15.4-beta now

Kixunil commented 2 years ago

Merged and I noticed a few things that I addressed in #22 please check it out.