Bump rustls and tonic version

Kixunil / tonic_lnd

Rust implementation of LND RPC client using async GRPC library `tonic`

31 stars 46 forks source link

Bump rustls and tonic version #31

Closed okjodom closed 1 year ago

okjodom commented 1 year ago

Changes

Bump rustls from v0.19.0 to v0.20.7
Bump tonic from v0.6.2 to v0.8.3

Motivation:

Instead of proposing a migration from rustls to openssl, we this PR proposes a version bump of the two dependencies and then a re-assessment of Issue #17 previously reported. In theory, we should not replicate issue #17 on the latest version of ruslts.

If the issue persists or presents in a different form after the version bump, we should consider patching ruslts, rather than migrate to openssl

Kixunil commented 1 year ago

Why bump tonic? It breaks MSRV. I'm OK with bumping MSRV to 1.63 after Debian Bookworm release though (should be in April).

okjodom commented 1 year ago

Why bump tonic? It breaks MSRV. I'm OK with bumping MSRV to 1.63 after Debian Bookworm release though (should be in April).

I'll track this as an issue and let's wait for April!

okjodom commented 1 year ago

See https://github.com/fedimint/tonic_lnd/pull/5 (fedimint fork of this library) for progress on version bump