search

Kiyokawa / pydicom

Automatically exported from code.google.com/p/pydicom
0 stars 0 forks source link

Update _dicom_dict.py from 2013 xml edition #148

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
New tags in the 2013 edition of DICOM are not present.

The changeset in 
https://code.google.com/r/rickardholmberg-pydicom/source/detail?r=1778457100335c
5c621e1d905a07fffe8319e8d4 contains a fix for this.

Original issue reported on code.google.com by rickard....@gmail.com on 23 May 2014 at 5:32

GoogleCodeExporter commented 8 years ago 
Note that the UID dictionary remains to be converted.

Original comment by rickard....@gmail.com on 23 May 2014 at 5:39

GoogleCodeExporter commented 8 years ago 
Here is the commit for updating the UID dictionary from the xml version of the 
standard: 
https://code.google.com/r/rickardholmberg-pydicom/source/detail?r=ca45e0ce44f9d1
bdc7826ead0275c1267cd7f5d9

Original comment by rickard....@gmail.com on 23 May 2014 at 8:43

GoogleCodeExporter commented 8 years ago 
Thanks Rickard.  The dictionaries were pulled in (revision 0272101630a5). I 
like the docbook code too but didn't pull it in just yet (nor the xml files, 
want to leave them out of pydicom).  I wanted to think about having the 
dependency on Beautiful Soup, but now that I think about it, we could make it 
only warn on that when run, as is done with Numpy.  Do you think the docbook 
code is robust? We could go with that for all future dictionaries if so.

Original comment by darcymason@gmail.com on 29 May 2014 at 2:18