Kiyomi-Parents / Kiyomi

A Discord bot centered around the Beat Saber community
MIT License
1 stars 1 forks source link

weighted pp change sometimes has +- in front of it instead of just + #12

Closed PatTheHyruler closed 3 years ago

PatTheHyruler commented 3 years ago

Screenshot_2021-07-20-19-34-00-643_com.discord.jpg

PatTheHyruler commented 3 years ago

also wait what the actual value of the change is strange as well, so I guess it just somehow ends up being negative

PatTheHyruler commented 3 years ago

another exampleScreenshot_2021-07-20-19-41-13-262_com.discord.jpg

PatTheHyruler commented 3 years ago

Finally took a look at this. I assume that this happens because the pp weight of the new score isn't the same it would've been, had it been set at the time as the old score. So, in order to make them compatible, we would need to get the new pp weight of the older score.

HOWEVER, since as far as I can tell, the ScoreSaber API doesn't currently let you find a specific score by scoreId, we'd need to look at the player's top scores to calculate it on our own. I suppose we could go through the player's top scores page by page on ScoreSaber, but since @LuCkEr- wanted to get the bot to download all the scores of every registered player anyway, maybe we can do something with that instead?

LuCkEr- commented 3 years ago

Fixed at refactor