search

KjellConnelly / react-native-rate

Send your app users to Apple App Store, Google Play, Amazon, or other using the newest APIs
635 stars 100 forks source link

Callback refinement when in-app rating dialog fails and "openAppStoreIfInAppFails" is false #19

Closed blah1234 closed 5 years ago

blah1234 commented 5 years ago

I ran into this use-case where I'm trying to show the in-app rating dialog, and I also set "openAppStoreIfInAppFails" to FALSE.

In this case, if the in-app rating dialog fails, nothing will happen, so it would seem to make sense that the callback returns false in this case, as the user is NOT taken to the app store.

KjellConnelly commented 5 years ago

Good catch blah! Thanks for the commit! I'm merging it now :)

blah1234 commented 5 years ago

Thanks! I can get rid of my local_node_module copy now.