search

KjellConnelly / react-native-rate

Send your app users to Apple App Store, Google Play, Amazon, or other using the newest APIs
635 stars 100 forks source link

Add Linting to the Project #20

Closed Zidail closed 5 years ago

Zidail commented 5 years ago

What

Adds linting to the project and reformats code to match the linting rules. Currently it uses AirBNB styling, but can be modified for anything you'd like.

To run the linter use yarn lint or npm run lint.

Why

Allows for contributors to catch issues in their code before going through review. Allows for a unifying code style so that contributions look similar to underlying codebase.

KjellConnelly commented 5 years ago

I personally don’t like semi colons. It feels like I’m using es5 and objective-C again. Since I’ve never used linting, can it still be supported without all the ; ?

Zidail commented 5 years ago

I personally don’t like semi colons. It feels like I’m using es5 and objective-C again. Since I’ve never used linting, can it still be supported without all the ; ?

No problem. We can remove all the ;. Just as an FYI, react-native uses es6.