React-namespace must be checked first to avoid going for normal import

KjellConnelly / react-native-rate

Send your app users to Apple App Store, Google Play, Amazon, or other using the newest APIs

635 stars 100 forks source link

React-namespace must be checked first to avoid going for normal import #35

Closed abidulrmdn closed 2 years ago

abidulrmdn commented 5 years ago

If you have dep loaded #import "lib" would work, so it doesn't go to react-namespace which mean for react-native>0.39 it will fail. So, you have to check for namespace first.

This is related to this issue: https://github.com/KjellConnelly/react-native-rate/issues/34

vpontis commented 4 years ago

@abdrmdn I tried patching this manually and it didn't work for me. I'll play around w/ it more...

KjellConnelly commented 2 years ago

I think I remember this being an issue for me awhile back, but it's been 2 years since this request was made and I haven't really done any development of react native modules in the meantime. So I'll just close this for now. If anyone has any issues (I am guessing this is no longer an issue with later versions of RN), just let me know.