search

KjellConnelly / react-native-rate

Send your app users to Apple App Store, Google Play, Amazon, or other using the newest APIs
642 stars 101 forks source link

Hack to determine if SKStoreReviewController was shown is not working on iOS 13.5 #60

Open rkrueger11 opened 4 years ago

rkrueger11 commented 4 years ago

Currently on iOS 13.5 w/ RN version 0.61.5 and the hack to determine if the SKStoreReviewController was shown is not working and instead always sends the user to the App Store.

robertpaul01 commented 4 years ago

This functionality seems to still work for me on iOS 13.5 simulators. Is this something you've seen on devices?

rkrueger11 commented 4 years ago

Yep - using an iPhone X.

robinalexandre commented 4 years ago

I just test it too and it's working but only the first time you show it. On this condition newWindowCount > originalWindowCount, the first time originalWindowCount is less than newWindowCount. But for some reasons, the next time they are both the same value.

Any help ?

KjellConnelly commented 4 years ago

I'm not sure why it isn't working at all for some of you (haven't been using the popup in my apps), but @robinalexandre this issue is detailed in my README under the iOS specifics section. Basically, once the window appears, it is still in the array of windows even after being dismissed. Probably crummy coding on part of the Apple Developers, but maybe it's intentional. Idk.

rolfb commented 4 years ago

Same here. App Store opens after the delay is up on iOS.

rolfb commented 4 years ago

with 

preferInApp: true,
openAppStoreIfInAppFails: false

success returns false even if the in app dialogue is shown

sshvaiko commented 3 years ago

Are there any updates? I have the same problem.

sergiivorobei commented 2 years ago

The issue is still reproducible on iOS 15. From the documentation and StackOverflow, it seems like there is no verified way to check whether the Review request was shown or not. So this hack on the library side can't be a recommended working solution, what we currently experience. So I would propose to either remove possiblyOpenAppStore completely to avoid this kind of random behavior or restrict it to some lower iOS version if it reliably works on them (for iOS 13.5, 15.0 this is not the case). What are your thoughs on this?

JestemTrzcinska commented 9 months ago

still an issue, any tips?