search

KjellConnelly / react-native-rate

Send your app users to Apple App Store, Google Play, Amazon, or other using the newest APIs
635 stars 100 forks source link

Support turbomodules in RNRateModule #79

Closed janicduplessis closed 2 years ago

janicduplessis commented 3 years ago

Turbomodules are the next version of native modules. These changes makes this module compatible.

janicduplessis commented 3 years ago

@KjellConnelly Any chance you could have a look at this?

KjellConnelly commented 2 years ago

I'm not sure of the implications of turbo modules, but it looks like they will be used somewhere around the end of this year. The react-native github page uses this sort of syntax for their own android modules, so I'm just going to merge and cross my fingers that it doesn't break anything. I believe androidX must be used. But who knows....

janicduplessis commented 2 years ago

@KjellConnelly The module annotation has existed for a few years, it is just not yet used. I've added it to many projects without issues so it should be fine :)

KjellConnelly commented 2 years ago

Ya I was googling it and saw it's been talked about for several years. Just looks like there hasn't been a full implementation yet as the RN docs still show the old way.