KjellConnelly / react-native-rate

Send your app users to Apple App Store, Google Play, Amazon, or other using the newest APIs
635 stars 100 forks source link

iOS Podspec file missing homepage #9

Closed imoby closed 6 years ago

imoby commented 6 years ago

I get an error when running pod install for RNRate. It says that homepage property is not configured in the podspec file.

Pod::Spec.new do |s|
  s.name         = "RNRate"
  s.version      = "1.0.0"
  s.summary      = "RNRate"
  s.description  = <<-DESC
                  RNRate
                   DESC
  s.homepage     = ""
  s.license      = "MIT"
  # s.license      = { :type => "MIT", :file => "FILE_LICENSE" }
  s.author             = { "author" => "author@domain.cn" }
  s.platform     = :ios, "7.0"
  s.source       = { :git => "https://github.com/author/RNRate.git", :tag => "master" }
  s.source_files  = "RNRate/**/*.{h,m}"
  s.requires_arc = true

  s.dependency "React"
  #s.dependency "others"

end

image

imoby commented 6 years ago

@KjellConnelly I've created a pull request to fix this issue: https://github.com/KjellConnelly/react-native-rate/pull/10

KjellConnelly commented 6 years ago

Thanks imoby! Haven’t used cocoapods with React Native before, and this module was initialized via a script, hence me leaving in the podspec that I never looked out. Will merge it now :)

imoby commented 6 years ago

@KjellConnelly any plans on when this will be published to npm?

KjellConnelly commented 6 years ago

@imoby Just published 1.0.9 to npm with your change :)