KjellConnelly / react-native-shared-group-preferences

127 stars 57 forks source link

Feature - target api 34 and add support for AGP 8 #36

Open Timi-Duban opened 3 months ago

Timi-Duban commented 3 months ago

Target android api 34 to be compatible with Play Store requirements, and add commit adapted from @AndreiCalazans work found in another project

Change to support AGP 8 as mentioned here: react-native-community/discussions-and-proposals#671

This does not remove package attribute from AndroidManifest to not lose compatibility with AGP < 8 (React Native < 0.71 versions).

I don't think it's worth maintaining logic to remove that attribute contitionally since it will only cause a warning to users on AGP 8 and above.