KjellKod / g3log

G3log is an asynchronous, "crash safe", logger that is easy to use with default logging sinks or you can add your own. G3log is made with plain C++14 (C++11 support up to release 1.3.2) with no external libraries (except gtest used for unit tests). G3log is made to be cross-platform, currently running on OSX, Windows and several Linux distros. See Readme below for details of usage.
http://github.com/KjellKod/g3log
The Unlicense
908 stars 271 forks source link

Is g3log compatible with C++ 14 or C++ 17 #501

Closed wluter closed 1 year ago

wluter commented 1 year ago

The home page for g3log says "G3log is made with plain C++14 (C++11 support" but it calls the template function std::invoke_result_t which is available only from c++ 17.

I am having difficulty compiling it with an MFC application due to version compatibility problems.

KjellKod commented 1 year ago

Hi. Thanks for calling that out. I need to clear that up in the documentation

Please check the release information for the last release that supported C++14

wluter commented 1 year ago

Thanks for the quick response

KjellKod commented 1 year ago

Please feel free to make a quick doc update/PR, or I’ll try to get to it in a week+ time when I’m back from archery Sent from my iPhoneOn Sep 9, 2023, at 06:36, wluter @.***> wrote: Thanks for the quick response

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

wluter commented 1 year ago

I took a look at updating and submit PR but wasn't sure how to change the web page where the error is.

KjellKod commented 1 year ago

That’s just one of the markdown files. You can use the search to find it Sent from my iPhoneOn Sep 11, 2023, at 13:41, wluter @.***> wrote: I took a look at updating and submit PR but wasn't sure how to change the web page where the error is.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

wluter commented 1 year ago

I have searched through every .md document and also performed a general search for “C++14” and “About” and I must be dumb. I cannot find the “About” abstract on the code tab: @.***

Regards, Bill

From: Kjell Hedström @.> Sent: Saturday, November 11, 2023 6:33 PM To: KjellKod/g3log @.> Cc: William Luter @.>; Assign @.> Subject: Re: [KjellKod/g3log] Is g3log compatible with C++ 14 or C++ 17 (Issue #501)

[EXTERNAL EMAIL] DO NOT CLICK links or attachments unless you recognize the sender and know the content is safe.

Assigned #501https://github.com/KjellKod/g3log/issues/501 to @wluterhttps://github.com/wluter.

— Reply to this email directly, view it on GitHubhttps://github.com/KjellKod/g3log/issues/501#event-10933431987, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADSO5FFB5OWEB6H5PCZ4RE3YEAKMLAVCNFSM6AAAAAA4RMIKWOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHEZTGNBTGE4TQNY. You are receiving this because you were assigned.Message ID: @.***>

CONFIDENTIALITY NOTE: The information contained in this message and any attachments here to are legally privileged and confidential information intended only for the use of designated recipients to whom it is addressed. Any reader of this message that is not the intended recipient is hereby notified that you have received this document in error and that any review, dissemination, distribution or copy of this message or its attachments is strictly prohibited. Please immediately notify the sender of such erroneous delivery by telephone, fax, or email and delete the message. Thank you.


此郵件(及其任何附件)含有機密、受特權或法律保護之訊息。該訊息僅供收件人(或負責轉交於公司之人員)閱讀。如您不是本訊息的指定收件人,請勿列印、保留、複製或傳播此訊息或其中任何一部份。如您錯收此訊息,請立即將此訊息從您的系統內銷毀或刪除,並通知寄件者。

KjellKod commented 1 year ago

completed in https://github.com/KjellKod/g3log/pull/502

KjellKod commented 1 year ago

@wluter I can recommend githelpers as a much nicer way to search in git repos, alternatively, just looking at their aliases and use something similar