Kl4rry / simp

đŸ–Œïž Simp is a fast and simple GPU-accelerated image manipulation program.
Apache License 2.0
307 stars 14 forks source link

trash-rs as optional feature #18

Closed 0323pin closed 2 years ago

0323pin commented 2 years ago

Hi,

NetBSD/pkgsrc maintainer here. Aiming at packaging simp for NetBSD, would it be possible to make trash an optional feature? trash-rs does not build on NetBSD, see https://github.com/Byron/trash-rs/issues/56 for details.

Regards

Kl4rry commented 2 years ago

Yes I can make trash-rs an optional dependency.

0323pin commented 2 years ago

Great, thanks! I'll wait for it and give it another go at packaging.

0323pin commented 2 years ago

Tack. Återkommer nĂ€r jag har haft tid att testa det.

0323pin commented 2 years ago

All good! Tack!

http://mail-index.netbsd.org/pkgsrc-wip-changes/2022/09/16/msg024970.html

2022-09-16-192003_1366x768_scrot

Will import the package once the commit freeze due to branching is over.

0323pin commented 1 year ago

@Kl4rry Hej! InsÄg att 3.3.1 fanns i crates.io men det finns ingen tag hÀr i Github. Jag har nu byggt den lokalt och allt fungerar bra. Men, just nu har vi en freeze inför stable branch release. Vet du om den bygger med rust-1.64? Om ja, kan jag pusha den idag sÄ den hinner med innan release

Jag undrar ocksÄ om det Àr möjligt att hÄlla Github och crates.io i sync. Jag anvÀnder nÀmligen RSS feeds frÄn Github för att tracka mina paket.

Tack, och trevlig jul.

Kl4rry commented 1 year ago

@0323pin I forgot 💀 to upload to github. Do you know if it possible to automate it with github actions? It is not possible to build because epaint a egui dependency requires 1.65 Ă€r newer.

Go jul

0323pin commented 1 year ago

Do you know if it possible to automate it with github actions?

Should be, I've asked for this before in other projects but, I'm not a github expert.

epaint a egui dependency requires 1.65

Thanks! I need to leave it until after the branch freeze, then. Rust-1.65 should be merged shortly after, I hope. I'm running 1.66 myself and sometimes (it happens), I merge things that have to be reverted.

0323pin commented 1 year ago

@Kl4rry FYI, https://github.com/rust-lang/libc/pull/3368

0323pin commented 1 year ago

@Kl4rry Hi! Combining libc-0.2.149 and trash-rs-3.1.0 allows the trash feature to build and function on NetBSD.