search

KlausT / ccminer-cryptonight

Software for mining various cryptocoins, like Monero (pool mining only)
GNU General Public License v3.0
133 stars 30 forks source link

Cryptonightv7 #69

Open alexsggit opened 6 years ago

alexsggit commented 6 years ago

Hello,

did you plan to add support for cryptonightV7 POW? As you know some coins (monero, aeon, stellite, etc...) already forked to that new POW and, given that your miner is the best out there (for me at least) I really appreciate if you add V7 :-)

Best

Update: After reviewing the code, seems that support is already there. The problem seems that the variant detection fails for other coins but monero. I mean that, for example, stellite (coin which I am interested in, but not limited to) that forked to new POW does not work. Looking at the code from other miners (which I dislike btw) eg. xmr-stak, they did the support differently, that is: based on the coin name! Maybe it could the the case to review that code from other miners and provide configuration params in order to better support the new POW algo?

KlausT commented 6 years ago

I have added an option now where you can choose between the old and the new algo. -a cryptonight for the old algo (works for Graft until the fork, didn't test other coins) -a monero for the new algo (the default right now) I don't know yet if the other forked coins will use the exact same algo as Monero, or what the differences are. I will have to see if there's any info about it.

KlausT commented 6 years ago

This will get ridiculous really fast if I have to add a special case for every coin. Oh well, time to add another option, like --forkversion = 7

goldmang commented 6 years ago

Hmm, what about cryptonight-heavy variant used by sumo?

alexsggit commented 6 years ago

Well, I rebuilt the miner from trunk (under Windows) and tried both cryptonight and monero -a switching options but it doesn't work for stellite :-(

Can you please fix it?

Update: I am sure that stellite uses the forkversion = 3.

KlausT commented 6 years ago

Yeah. I just made a change. It should work now when using the -a stellite option

alexsggit commented 6 years ago

Eureka! It works like a charm :-) Thank you very much Klaus!

nemosminer commented 6 years ago

tested on nicehash cryptonightV7 stratum with -a cryptonightV7 it works great... also tested -a cryptonight on cryptonight stratum both are working correctly

Fjodor42 commented 6 years ago

Electroneum switched to cryptonightv7 very recently - when running with -a monero, I still get reject reason: Rejected share: invalid result, though.

What can I do to help?