Kleak / international_system_of_units

The most complete unit converter for Dart/Flutter which also do localizations
11 stars 12 forks source link

upgrade to intl 17.0 #30

Open Miamoto-Musashi opened 3 years ago

Miamoto-Musashi commented 3 years ago

Describe the bug need to upgrade to intl 17.0

To Reproduce Steps to reproduce the behavior:

  1. Upgrade flutter to 2.0
  2. Go to project root
  3. Perform flutter pub get

Expected behavior Project Compiles

Running "flutter pub get" in project...                       
Because international_system_of_units 1.0.0-dev.4 depends on intl ^0.16.1 and no versions of international_system_of_units match >1.0.0-dev.4 <2.0.0, international_system_of_units ^1.0.0-dev.4 requires intl ^0.16.1.

So, because project depends on both international_system_of_units ^1.0.0-dev.4 and intl ^0.17.0, version solving failed.
pub get failed (1; So, because project depends on both international_system_of_units ^1.0.0-dev.4 and intl ^0.17.0, version solving failed.)
exit code 1
Kleak commented 3 years ago

in fact i can't update this due to intl_translation plugin not compatible with intl 0.17.0 as in dart-lang/intl_translation#29 as soon as a version is compatible i will publish an update

louisdeveseleer commented 3 years ago

It looks like the issue has been solved on the intl_translations side, does that unblock your issue? https://github.com/dart-lang/i18n/issues/563

Love your package by the way, makes it so so easy to handle different units without having to spend the time creating all these enums and const values.

Kleak commented 3 years ago

The generated code from intl_translation iOS not compatible with null safety.

As soon as it's compatible I will provide a null safe version of the package. Hopefully it will not took too long before they update it.

vincentvulog commented 3 years ago

Hi @Kleak any news on the subject ? or a way to track the ios issue ?

Kleak commented 3 years ago

as you can see on pub intl_translation is not null safe compliant for now https://pub.dev/packages/intl_translation waiting on it to be and will push a new version everything is ready on my side ;)

vincentvulog commented 3 years ago

Do you think this null safe version could be a good fit ? https://pub.dev/packages/intl_utils was mentioned here https://github.com/dart-lang/i18n/issues/573

Kleak commented 3 years ago

would prefer to stay on the official one.

Miamoto-Musashi commented 3 years ago

any news on this?

Letalus commented 2 years ago

pull request regarding this issue in https://github.com/Kleak/international_system_of_units/pull/33