Support addField and append directly with derived ModelNode types.

Klebert-Engineering / simfil

The Simple Map Filter Language Interpreter 🌳.

BSD 3-Clause "New" or "Revised" License

6 stars 0 forks source link

Support addField and append directly with derived ModelNode types. #57

Closed josephbirkner closed 11 months ago

josephbirkner commented 11 months ago

Fixes #48

We were always explicitely casting from shared_model_ptr<Derived> to shared_model_ptr<ModelNode>. This is now not necessary anymore when calling Object::addField or Array::append.

github-actions[bot] commented 11 months ago

Test Results

  1 files ±0   1 suites ±0 11s :stopwatch: ±0s 39 tests ±0 39 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 40 runs ±0 40 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0

Results for commit 7fded10e. ± Comparison against base commit 97f3da12.

github-actions[bot] commented 11 months ago

Package	Line Rate	Branch Rate	Health
include.simfil	55%	37%	➖
include.simfil.model	74%	63%	➖
src	63%	35%	➖
src.model	77%	42%	➖
Summary	65% (2304 / 3529)	37% (1921 / 5200)	➖

Minimum allowed line rate is 50%