Klebert-Engineering / simfil

The Simple Map Filter Language Interpreter 🌳.
BSD 3-Clause "New" or "Revised" License
6 stars 0 forks source link

deps/bitsery: Use lower-case only in FetchContent to fix silently failing fetching of bitsery. #71

Closed MisterGC closed 8 months ago

MisterGC commented 8 months ago

At least when using emscripten based cross-compilation for erdblick, the bitsery dependency was not fetched properly. There was not source/build dir in the _deps dir. Not sure if it was hidden somewhere else but at the end this caused a linker error, because of the non-present bitsery library. This PR just changes to all-lower-case. I think it is somehow related to the way cmake populates variables when using FetchContent, but I don't know for sure. Nevertheless, I guess this should not have any negative side-effect but makes the cross-compilation work.

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

github-actions[bot] commented 8 months ago
Package Line Rate Branch Rate Health
include.simfil 61% 42% βž–
include.simfil.model 82% 59% βœ”
src 63% 36% βž–
src.model 79% 44% βž–
Summary 68% (2497 / 3684) 38% (2042 / 5335) βž–

Minimum allowed line rate is 50%

github-actions[bot] commented 8 months ago

Test Results

 1 files  Β±0   1 suites  Β±0   3m 5s :stopwatch: -1s 40 tests Β±0  40 :white_check_mark: Β±0  0 :zzz: Β±0  0 :x: Β±0  41 runsβ€Š Β±0  41 :white_check_mark: Β±0  0 :zzz: Β±0  0 :x: Β±0 

Results for commit 8fe9e5bd. ± Comparison against base commit 200750a7.