Klebert-Engineering / simfil

The Simple Map Filter Language Interpreter 🌳.
BSD 3-Clause "New" or "Revised" License
6 stars 0 forks source link

Fix string pool lookup performance #97

Closed josephbirkner closed 1 week ago

josephbirkner commented 2 weeks ago

The naive lookup using a lower-case string copy is now really starting to impact performance during model building quite badly. So, here is a fix :smile:

github-actions[bot] commented 2 weeks ago

Test Results

 1 files  Β±0   1 suites  Β±0   3m 12s ⏱️ +13s 36 tests Β±0  36 βœ… Β±0  0 πŸ’€ Β±0  0 ❌ Β±0  37 runsβ€Š Β±0  37 βœ… Β±0  0 πŸ’€ Β±0  0 ❌ Β±0 

Results for commit 9363b221. ± Comparison against base commit df138085.

:recycle: This comment has been updated with latest results.

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
12 New issues
43 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 1 week ago
Package Line Rate Branch Rate Health
include.simfil 64% 47% βž–
include.simfil.model 87% 61% βœ”
src 72% 41% βž–
src.model 83% 51% βœ”
Summary 74% (2141 / 2875) 44% (1776 / 4017) βž–

Minimum allowed line rate is 50%