search

Kleidukos / get-tested

Go get tested! Github Actions matrix generator for your haskell projects' CI
BSD 3-Clause "New" or "Revised" License
45 stars 3 forks source link

Only take precise versions and reject version ranges #7

Closed Kleidukos closed 1 year ago

Kleidukos commented 1 year ago

We should encourage people to use the exact-version syntax, and not use version ranges. For instance

tested-with: GHC == { 8.6.3, 8.4.4, 8.2.2, 8.0.2, 7.10.3, 7.8.4, 7.6.3, 7.4.2 }

or

tested-with: GHC == 8.6.3, GHC == 8.4.4, GHC == 8.2.2, GHC == 8.0.2,
             GHC == 7.10.3, GHC == 7.8.4, GHC == 7.6.3, GHC == 7.4.2

This frees us from having to maintain a whitelist.

andreasabel commented 1 year ago

Or the diff-friendly line-wise syntax maybe, which I prefer:

tested-with: 
  GHC == 8.6.3
  GHC == 8.4.4
  GHC == 8.2.2
  GHC == 8.0.2
  GHC == 7.10.3
  GHC == 7.8.4
  GHC == 7.6.3
  GHC == 7.4.2
Kleidukos commented 1 year ago

Yes, in the end it's the version ranges that we should avoid, they're absolutely tricky to validate without maintaining a whitelist.