Kleo-Network / connect-backend

connect-backend
MIT License
0 stars 3 forks source link

Feat/fix speed #41

Closed vaibhavgeek closed 3 weeks ago

vaibhavgeek commented 3 weeks ago

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, as well as any relevant images for UI changes.

Added tests?

Added to documentation?

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

alt_text

gitguardian[bot] commented 3 weeks ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [14364577](https://dashboard.gitguardian.com/workspace/62683/incidents/14364577?occurrence=169619327) | Triggered | Username Password | 19418cda45e642630ed6a318c8e982c415f47e87 | app/celery/config.py | [View secret](https://github.com/Kleo-Network/connect-backend/commit/19418cda45e642630ed6a318c8e982c415f47e87#diff-2907406d89b1d4647b6b59e3bfeca21151463afb19d795c3bc5e56617541017eL32) | | [14364577](https://dashboard.gitguardian.com/workspace/62683/incidents/14364577?occurrence=169619606) | Triggered | Username Password | bb9787d13a1d2d316e71ae9cf139f4dc3fcfec71 | app/celery/config.py | [View secret](https://github.com/Kleo-Network/connect-backend/commit/bb9787d13a1d2d316e71ae9cf139f4dc3fcfec71#diff-2907406d89b1d4647b6b59e3bfeca21151463afb19d795c3bc5e56617541017eL33) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/username_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.