search

KlimaDAO / klimadao

Monorepo for the official KlimaDAO site, dApp, components and design system.
https://klimadao.finance
MIT License
92 stars 74 forks source link

[API] Update subgraph version to include `UpdatedExpiration` event #2245

Closed psparacino closed 7 months ago

psparacino commented 7 months ago

Description

The listings issue described below appears to be a casing issue in the frontend.

This updates the subgraph (current version breaks on activities query as there are null projects for some entities due to an uncaught case) to handle expiration date only updates.

Related Ticket

Related to #2243

How to Test

  1. got to https://carbonmark-git-tufnel-fix-listings-not-showing-klimadao.vercel.app/users/jabby
  2. confirm expired listings are there
vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 0:25am
carbonmark ✅ Ready (Inspect) Visit Preview Feb 13, 2024 0:25am
carbonmark-api ✅ Ready (Inspect) Visit Preview Feb 13, 2024 0:25am
demo-integration ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 0:25am
klimadao-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 0:25am
jabby09 commented 7 months ago

@psparacino @biwano

I'm not sure this fixes the issue. My understanding is that the user should always see their own expired listings even after 90 days.

Can we not just provide a large value for expiresAfter on the call to the api from the consumer (app)

@0xemc correct this is not completely fixed, Peter is working on it https://discord.com/channels/1135827610434289727/1204433909060730900/1204862568926281848

0xemc commented 7 months ago

@jabby09 @0xtapi can we give this PR the greenlight?

jabby09 commented 7 months ago

@jabby09 @0xtapi can we give this PR the greenlight?

hey @0xemc I believe this is working now but I'm doing some final FE testing on this PR https://github.com/KlimaDAO/klimadao/pull/2255

psparacino commented 7 months ago

@jabby09 The reverting calls on those expired listing occurred because those listings had actually already been deleted by the contract due to having less than the minimum fill amount. There was no event emitted so the subgraph didn't pick it up. The issue was fixed and new events emitted to update the subgraph so that should be separate from this issue

0xemc commented 7 months ago

Closing after ticks from all parties