search

KlimaDAO / klimadao

Monorepo for the official KlimaDAO site, dApp, components and design system.
https://klimadao.finance
MIT License
90 stars 71 forks source link

[Carbonmark] Fix ICR retire from seller listing #2276

Closed psparacino closed 4 months ago

psparacino commented 4 months ago

Description

The original values for retire from listing were passing parsed values for ICR quantities which led to the contract rejecting the quantities.

These values have been adjusted for ICR credits.

To avoid this in the future we need to create a util function for the FE similar to this PR: https://github.com/KlimaDAO/klimadao/pull/2189

TokenId also added to the struct

There's also a secondary issue, tracked here https://github.com/KlimaDAO/klimadao/issues/2280, where KlimaInfinity and RetirementAggregatorV2 are being used interchangeably with out of sync abis in carbonmark.

This caused some lost time for this PR and could definitely cause confusion in the future. We should pick one name, use updated abi under that name and remove change references to the other name throughout carbonmark/

How to Test

  1. Retire Now from one of these listings: https://www.carbonmark.com/projects/ICR-112-2019
  2. The txn should complete successfully
vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 3:57pm
carbonmark ✅ Ready (Inspect) Visit Preview Feb 19, 2024 3:57pm
carbonmark-api ✅ Ready (Inspect) Visit Preview Feb 19, 2024 3:57pm
demo-integration ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 3:57pm
klimadao-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 3:57pm
psparacino commented 4 months ago

Converted to draft; further changes needed on this