search

KlimaDAO / klimadao

Monorepo for the official KlimaDAO site, dApp, components and design system.
https://klimadao.finance
MIT License
90 stars 71 forks source link

[Klimadao/klimadao] KlimaInfinity and RetirementAggregatorv2 ABIs duplicate/out of sync #2280

Closed psparacino closed 4 months ago

psparacino commented 4 months ago

Describe the bug KlimaInfinity and RetirementAggregatorV2 are two different names for the same contract. Right now in lib/ and the frontend both are being used interchangeably and there are two abis (of different versions) for each contract. This is causing issues when the versions fall out of sync or when developers don't know the other exists and are testing against an old abi.

Expected behavior We should decide on one name for that contract, retirementAggregatorV2 is probably clearer, use only that updated abi and change all other references to the alternate name to the decided on name.

Atmosfearful commented 4 months ago

Agreed, let's go with retirementAggregatorV2

sprrwhwk commented 4 months ago

I added KlimaInfinity back when we started with fiat for listings and didn't want to break anything with consumers of the other contract. In its current state they should be identical so we can just nuke KlimaInfinity and replace its usages with retirementAggregatorV2.