search

KlimaDAO / klimadao

Monorepo for the official KlimaDAO site, dApp, components and design system.
https://klimadao.finance
MIT License
90 stars 71 forks source link

[retirement] ICR retirements are breaking receipt design #2285

Closed jabby09 closed 4 months ago

jabby09 commented 4 months ago

ICR projects are breaking our receipt design, see https://www.carbonmark.com/retirements/0x6476edf98bdc5ee62f9d4e4bf8932d69ed685483/44 for example

image

does not seem to be maintaining the equal 2 column layout.

PDF layout seems fine. retirement_44_0x6476edf98bdc5ee62f9d4e4bf8932d69ed685483 (3).pdf

jabby09 commented 4 months ago

comment from Brendan

it's because that project value is a huge number Normally its VCS-191 Probably passing the wrong value down there

jabby09 commented 4 months ago

comment from Peter

I actually made this change in the subgraph to change that ICR project id to the standard format, but it hasnt' been approved, merged or deployed yet. But that should solve that issue

jabby09 commented 4 months ago

See https://github.com/KlimaDAO/klima-subgraph/pull/115 which should fix the receipt

Atmosfearful commented 4 months ago

@psparacino This appears in the codebase twice:

   // temporary fix until ICR digital-carbon id matches registry-registryProjectId format
    if (retirement.retire.credit.project.registry === "ICR") {
      retirement.retire.credit.project.projectID =
        retirement.retire.credit.project.id;
    }

reminder to clean that up when the subgraph fix goes in

jabby09 commented 4 months ago

will leave this open until confirmed that subgraph change https://github.com/KlimaDAO/klima-subgraph/pull/115 fixes the receipts without a need for any FE updates

jabby09 commented 4 months ago

this is now resolved https://www.carbonmark.com/retirements/0x6476edf98bdc5ee62f9d4e4bf8932d69ed685483/48