search

KlimaDAO / klimadao

Monorepo for the official KlimaDAO site, dApp, components and design system.
https://klimadao.finance
MIT License
90 stars 71 forks source link

[retirements] fix project id on retirement page for ICR projects #2289

Closed sprrwhwk closed 4 months ago

sprrwhwk commented 4 months ago

Description

This PR fixes the project id on the retirements page which was showing a long number for ICR projects.

Related Ticket

Closes #2285

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 4:06pm
carbonmark ✅ Ready (Inspect) Visit Preview Feb 20, 2024 4:06pm
carbonmark-api ✅ Ready (Inspect) Visit Preview Feb 20, 2024 4:06pm
demo-integration ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 4:06pm
klimadao-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 4:06pm
sprrwhwk commented 4 months ago

This fixes the UI issues on the page.

However, the Learn More link is being constructed with the long id and results in 404 page https://carbonmark-git-2285-fix-project-id-on-retirements-page-klimadao.vercel.app/projects/87525131485654382824957055535282281802959500504925522089844996918187118841064-2019

Question:

1. Why is the project description not being included on the receipt?

@jabby09 the "learn more"-url is fixed now. I don't understand your question however.

jabby09 commented 4 months ago

@jabby09 the "learn more"-url is fixed now. I don't understand your question however.

Non-ICR receipt pages include the project description, so for example https://www.carbonmark.com/retirements/0x6476edf98bdc5ee62f9d4e4bf8932d69ed685483/46

On my ICR receipt pages, the project description you see here (https://www.carbonmark.com/projects/ICR-112-2019) IS NOT being shown on the retirement receipt.

jabby09 commented 4 months ago

Non-ICR receipt pages include the project description, so for example https://www.carbonmark.com/retirements/0x6476edf98bdc5ee62f9d4e4bf8932d69ed685483/46

On my ICR receipt pages, the project description you see here (https://www.carbonmark.com/projects/ICR-112-2019) IS NOT being shown on the retirement receipt.

@sprrwhwk does this make sense now?

sprrwhwk commented 4 months ago

Obsoleted by https://github.com/KlimaDAO/klima-subgraph/pull/115