search

KlimaDAO / klimadao

Monorepo for the official KlimaDAO site, dApp, components and design system.
https://klimadao.finance
MIT License
90 stars 71 forks source link

[provenance] 2281 Fix provenance page bugs #2295

Closed sprrwhwk closed 4 months ago

sprrwhwk commented 4 months ago

Description

This PR replaces the string "Bridge" with "Transfer" on the provenance receipt page.

Related Ticket

Closes #2281 Also related to

How to Test

Visit https://carbonmark-git-2281-get-rid-of-bridge-term-klimadao.vercel.app/retirements/0x087a7afb6975a2837453be685eb6272576c0bc06/6/provenance

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 2:50pm
carbonmark ✅ Ready (Inspect) Visit Preview Feb 22, 2024 2:50pm
carbonmark-api ✅ Ready (Inspect) Visit Preview Feb 22, 2024 2:50pm
demo-integration ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 2:50pm
klimadao-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 2:50pm
sprrwhwk commented 4 months ago

@sprrwhwk I think you missed the full requirements of this issue, I tagged you in this comment #2281 (comment)

Updated designs

A few changes were necessary here:

1. changed "Bridge" to "Transfer"

2. changed "Transfer" to "Send"

3. Added info icon w/ tooltip explaining that a Send is when an "Asset moved from one account to another, either via sale or inter-account transfer."

4. Changed "view/hide XX transfers" to "view/hide XX transactions"

image

I had missed that indeed @jabby09. I worked with the original issue comment at first.

I've addressed all of your requirements now. Can you have another look?

sprrwhwk commented 4 months ago

Good catch with the stretched icons @jabby09. It looks like this now:

grafik

Can you try removing any locale from the url (e.g. carbonmark.com/de/… and reloading the page? The {numberOfTransfers} is caused by our translation tooling.

jabby09 commented 4 months ago

Can you try removing any locale from the url (e.g. carbonmark.com/de/… and reloading the page? The {numberOfTransfers} is caused by our translation tooling.

@sprrwhwk hmmm....no locale in this url and still seeing the issue https://carbonmark-git-2281-get-rid-of-bridge-term-klimadao.vercel.app/retirements/0x087a7afb6975a2837453be685eb6272576c0bc06/6/provenance