KlimaDAO / klimadao

Monorepo for the official KlimaDAO site, dApp, components and design system.
https://klimadao.finance
MIT License
90 stars 71 forks source link

2254 token usdc vs usdce clarificationsupport #2318

Closed ChazSchmidt closed 4 months ago

ChazSchmidt commented 4 months ago

Description

The original USDC token has been changed to USDC.e on the Polygon blockchain. This PR clarifies that we currently support USDC.e by changing the UIs of Carbonmark and Klima app to display USDC.e wherever USDC was previously displayed. Mentions of USDC in the API descriptions has also been changed to USDC.e for clarification.

Related Ticket

Closes #2254

Notes For QA

Specific pages, components or journeys that might be affected:

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 6:51pm
carbonmark ✅ Ready (Inspect) Visit Preview Feb 22, 2024 6:51pm
carbonmark-api ✅ Ready (Inspect) Visit Preview Feb 22, 2024 6:51pm
demo-integration ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 6:51pm
klimadao-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 6:51pm
0xtapi commented 4 months ago

Still USDC here in headline: https://carbonmark-git-2254-token-usdc-vs-usdce-clarifi-81c4f8-klimadao.vercel.app/blog/how-to-get-usdc-or-matic

Something is going on here: https://carbonmark-git-2254-token-usdc-vs-usdce-clarifi-81c4f8-klimadao.vercel.app/resources

Search function is not working and it shows "resources.form.categories.subheader" to the left under "Categories". Not sure if this is related to this PR. Can changing text from USDC to USDC.e break a search function?

Similar problems in some forms, like here: Screenshot 2024-02-22 150440

ChazSchmidt commented 4 months ago

Still USDC here in headline: https://carbonmark-git-2254-token-usdc-vs-usdce-clarifi-81c4f8-klimadao.vercel.app/blog/how-to-get-usdc-or-matic

:sweat_smile: oops, how'd I miss that? fixed.

Search function is not working and it shows "resources.form.categories.subheader" to the left under "Categories". Not sure if this is related to this PR. Can changing text from USDC to USDC.e break a search function?

The string text errors in Resources are now fixed after a fresh lingui extract + compile. Correct me if I'm wrong. I don't think the search works on Vercel previews.

0xtapi commented 4 months ago

Search function is not working and it shows "resources.form.categories.subheader" to the left under "Categories". Not sure if this is related to this PR. Can changing text from USDC to USDC.e break a search function?

The string text errors in Resources are now fixed after a fresh lingui extract + compile. Correct me if I'm wrong. I don't think the search works on Vercel previews.

You're right, search doesn't work on previews.

Alright, almost good to go. Just one more USDC mention in this small preview snippet of the article (sorry, I didn't see this yesterday), then this is ready to merge: Screenshot 2024-02-23 140020