search

Klimaat-Helpdesk / website

Code behind https://www.klimaathelpdesk.org/
GNU General Public License v3.0
5 stars 5 forks source link

Links to personal expert pages open in same tab #69

Closed Arfor closed 3 years ago

Arfor commented 3 years ago

Eva suggested to have the links to the personal page (or twitter or linkedin) of an expert open in a new tab instead of over the KH website.

Arfor commented 3 years ago

I think it can be fixed by adding

target="_blank" rel="noopener noreferrer"

to the relevant hrefs in /klimaat_helpdesk/templates/experts/includes/expert_block.html

aquilesC commented 3 years ago

What would the rationale be for it? Why personal pages and not social media profiles?

Even though it can be done, it is bad practice from a UX perspective. If a user wants to navigate away from the website, they must be free to do so. And if they want to open the link on a separate window, they can also do so (right click, etc.). I, personally, prefer to stay away from these type of approaches that have no upside for our guests.

Also, why the noreferrer? Especially for experts pages, we should let them know if users are getting to their profiles from our website. That's something WordPress introduced as a standard, but that I don't find reasonable.

On Thu, Nov 19, 2020, 14:05 Arfor notifications@github.com wrote:

I think it can be fixed by adding

target="_blank" rel="noopener noreferrer"

to the relevant hrefs in /klimaat_helpdesk/templates/experts/includes/expert_block.html

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Klimaat-Helpdesk/website/issues/69#issuecomment-730361933, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATA7CE4MA2373THBFPDQUTSQUJYLANCNFSM4T3LVVJQ .

aquilesC commented 3 years ago

Closing due to lack of activity.