search

Klimatbyran / beta

New repo for new layout
2 stars 3 forks source link

(suspected) [BUG] Q-identifiers can change #155

Open LudwikJaniuk opened 1 week ago

LudwikJaniuk commented 1 week ago

IIUC WikiID / Q-identifiers are hardcoded on klimatkollen.se and are used as URL components to webpages (links which people could bookmark). At the same time, Garbo is IIUC permitted guess/lookup/generate the Q-id on each run. This seems like a recipe for errors - as soon as Garbo gets it wrong, the whole linking for the company collapses.

Unless I've understood the setup wrong, I think either Q-ids should not be used by us as URL components, or they should be kept stable by code.

Greenheart commented 1 week ago

Correct observation, and the source of several frustrating problems in the past days. The solution is likely to do the search with code, instead of letting Garbo guess wikidataId. I think I opened some issue(s) related to this in the https://github.com/Klimatbyran/garbo/ repo, but not sure of top of mind