Sparked by changes introduced with https://github.com/Klimatbyran/beta/pull/145, I tested it more thoroughly and tried implementing the suggested changes to turnover formatting. However, as mentioned in the review comment it wasn't as easy as expected.
TODO:
[ ] Ensure turnover data is correct and reports the correct unit. For example we need to solve inconsistencies causing some companies to return a value that would be MSEK but still reporting the unit as SEK, which is misleading and hard for the frontend to format properly. These changes need to happen in the API, but need to be tested together with the frontend, which is why the issue is opened in the beta repo.
[ ] Update frontend code to format turnover correctly based on the unit + prefix. For example, handle units with M, k and other prefixes.
Sparked by changes introduced with https://github.com/Klimatbyran/beta/pull/145, I tested it more thoroughly and tried implementing the suggested changes to
turnover
formatting. However, as mentioned in the review comment it wasn't as easy as expected.TODO:
MSEK
but still reporting theunit
asSEK
, which is misleading and hard for the frontend to format properly. These changes need to happen in the API, but need to be tested together with the frontend, which is why the issue is opened in the beta repo.M
,k
and other prefixes.