search

Klimatbyran / garbo

Klimatkollen's data pipeline, processing company sustainability reports
3 stars 6 forks source link

Add new env variable to README #105

Closed Greenheart closed 5 months ago

Greenheart commented 5 months ago

Resolves https://github.com/Klimatbyran/garbo/pull/103#discussion_r1587552270

DISCORD_WORKER seems like an optional env variable. Is this correct? Is this used differently between for example dev and prod?

irony commented 5 months ago

This variable is used to exclude some login commands for workers. Maybe we should find a better and more descriptive name?

Greenheart commented 5 months ago

Ah, yeah it makes sense from the code. Would likely be worth clarifying the purpose via the env variable name.

Any suggestion?

irony commented 5 months ago

It is an internal optional variable used by the infrastructure. I'm not sure we need to clarify its use in the README. Maybe it's better to find a way to not use enviroment variable at all for this purpose.

Greenheart commented 5 months ago

Not sure, and with the context here I think we can leave this for now. More important things to consider :)