search

Klimatbyran / klimatkollen

https://www.klimatkollen.se
MIT License
36 stars 44 forks source link

Fixes #463 #579

Closed N-Asadnajafi closed 1 week ago

N-Asadnajafi commented 2 weeks ago

Removed the unneeded Borna font assets from the public directory. Please see the differences in the main product and in my local in this picture:

Screenshot 2024-05-15 at 16 01 45
vercel[bot] commented 2 weeks ago

Someone is attempting to deploy a commit to the Klimatbyrån Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
klimatkollen ✅ Ready (Inspect) Visit Preview May 21, 2024 3:35pm
LudwikJaniuk commented 2 weeks ago

This changes how the page looks. I'm not sure it's "unneeded" then (quoting https://github.com/Klimatbyran/klimatkollen/issues/463). @Greenheart given that we're moving to a new typeface for klimatkollen, please weigh on which font is the one to be used going forward.

Greenheart commented 1 week ago

Thanks for taking a look at this Narges!

I gave unclear instructions in #463, and like Ludvig mentioned I should have defined what I meant with "unneeded Borna font assets". Going forward, I will try to add more context to issues to define the goals with each update we want to make. And please let me know if anything needs to be clarified :)

For #463, what I had in mind was to remove the testing files (primarily the html files) from public/fonts/Borna/webfontkit/**/*.html.

I'm updating the all fonts and colors as part of #590, but until then we should keep the website look intact. Thus, I will make changes to this PR so it's ready to merge, and then continue in my other branch with updating the font and colors.

Finally, a side note:

@LudwikJaniuk Perhaps we should also look into creating an GitHub issue template, to automatically get a good structure when we create issues. Here's some inspiration: https://github.com/29ki/29k/tree/main/.github/ISSUE_TEMPLATE

Most importantly, we need a clear definition of "done" for each issue, to make it easier to understand the evaluation criteria to get a PR merged.

LudwikJaniuk commented 1 week ago

Agreed on the side note. I'll look into it.