Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
9.5k stars 5.32k forks source link

Problems with arc movements when using offset (g2/g3 does not get executed) #2732

Closed ghost closed 4 years ago

ghost commented 4 years ago

I'm running a simple g-code, which runs fine and behaves as expected:

G1 x63 y61.150 G3 x63.000000 y61.150000 i0.000000 j-2.450000

All it does is go to a certain coordinate and perform a 360° loop there

However, if I set an offset SET_GCODE_OFFSET X=0 Y=10 Z=0, the g3 command can not get processed anymore. Some offsets work, some don't. Offset X=0 y=1 works fine.

The error message from the console is: could not tranlate from 'N2 G3 x63.000000 y61.150000 i0.000000 j-2.450000*2'

Without the offset I get no such error message and a correct movement.

(Note: it was directly copied from the console, including the missing s in tranlate)

klippy.log

KevinOConnor commented 4 years ago

Perhaps @achmed20 has some thoughts?

-Kevin

KevinOConnor commented 4 years ago

I think this should be fixed now (commit 402110f6).

-Kevin