Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
9.4k stars 5.3k forks source link

Adding official support for ADXL343 and ADXL346 #5648

Closed Max-Roesenberger closed 2 years ago

Max-Roesenberger commented 2 years ago

the ADXL343 is already unofficially supported due to having the same device ID as the ADXL345. the ADXL346 has the same adresses and general functionality as the ADXL345 and is a drop in replacement exept for the different device ID. I have bodged the ADXL345.py on my printer to accept the different device ID and the ADXL346 is working flawlessly. I attached my klippy.log and my bodged python code. The bodge is adding the id of the ADXL346 in line 23 and making the code accept that id in line 375.

klippy.log adxl345.py.txt

Sineos commented 2 years ago

There seem to be some differences between the 345 and 346. See https://ez.analog.com/mems/f/q-a/81958/adxl345-adxl346 Don't know if it has an effect on the measurement. Ping @dmbutyugin

Max-Roesenberger commented 2 years ago

From my understanding its about the least significant bit being 0 since it falls outside the valid data range. so the 0 is just a defined state.

github-actions[bot] commented 2 years ago

Hello,

It looks like there hasn't been any recent updates on this Klipper github issue. If you created this issue and no longer consider it open, then please login to github and close the issue. Otherwise, if there is no further activity on this thread then it will be automatically closed in a few days.

Best regards,

~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.