Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
9k stars 5.18k forks source link

Apparent regression in variable PA #6338

Closed richfelker closed 9 months ago

richfelker commented 9 months ago

Commit 29724a741106 moved the PA constant from being a property of the move to a property of the extruder. As far as I can tell, this broke configurations with variable PA, e.g. use of a lower K for bridges where there's no backpressure, by performing the integration with a single K that's whatever happens to have been the most-recent-set at the time of the iterative solver running, rather than using potentially differing-per-move K values in the integration.

My proposal for fixing this would be reverting the changes to chelper and the representation of PA K in trapq, and instead having the Python side copy the PA K from the relevant extruder object to the moves when adding them to the trapq.

github-actions[bot] commented 9 months ago

It looks like this ticket is a request for help (or similar). Many helpful people will not see your message here and you are unlikely to get a useful response. Instead, see the contact directions at: https://www.klipper3d.org/Contact.html

We use github to share the results of work done to improve Klipper. We don't use github for requests. (In particular, we don't use github for feature requests, to answer questions, nor to help diagnose problems with a printer.)

Please follow the directions at: https://www.klipper3d.org/Contact.html

This ticket will be automatically closed.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

richfelker commented 9 months ago

This is not a request for help, silly bot. It's a report citing a particular commit and describing the regression it introduced.

Sineos commented 9 months ago

As you surely noticed, this project has no possibility to open a new issue. To simply outsmart this fact seems rather brazen to me. Please either open a PR or follow the given instructions.

ganzgustav22 commented 5 months ago

@Sineos But apart from richfelker being a naughty boy, have you maybe considered fixing it?

Sineos commented 5 months ago

You might want to open a topic in Discourse as this is still not considered the right place to discuss it.

ganzgustav22 commented 5 months ago

No thanks, I'm happy with Danger Klipper.

richfelker commented 1 week ago

Opened thread in the proper place here: https://klipper.discourse.group/t/regression-in-dynamic-pa/17260