search

Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
9k stars 5.18k forks source link

pid_calibrate: allowing TUNE_PID_DELTA to pass through gcode #6346

Closed SHKinsem closed 8 months ago

SHKinsem commented 9 months ago

I have utilized the Bambulab hotend paired with a 70W ceramic heater cartridge. After extensive testing, it became evident that this setup exhibited an exceptionally rapid temperature response. This led to an issue where the original delta value was too small, causing the temperature sensor to be unable to collect data quickly enough, resulting in suboptimal PID calibration parameters. By adjusting the delta value, significant improvements can be achieved in the effectiveness of the automatic calibration process.

Signed-off-by: Jaccob Hui 783739330@qq.com

SHKinsem commented 9 months ago

With the change, new command would be 'PID_CALIBRATE HEATER= TARGET= TUNE_PID_DELTA=' if TUNE_PID_DELTA is not specified, default value would be 5.0

github-actions[bot] commented 9 months ago

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

github-actions[bot] commented 8 months ago

Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.