Closed bitingsock closed 8 months ago
A tool for tuning a parameter on each Z height during a print.
Isn't it quite common that a print requires extrusion? ¯\_(ツ)_/¯
Of course, and while the edge case of using klipper outside of FDM is probably pretty rare, I think, used as a tuning/debugging tool it would be useful to be able to run gcode like:
G0 Z0.1
G0 Z0.2
G0 Z0.3
...
So the proper solution may be to re-engineer the code to only require extrusion for extrusion related commands.
Thank you for submitting a PR, please could you refer to point 3 in the "what to expect" section in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and add a signed-off-by line.
Thanks James
So the proper solution may be to re-engineer the code to only require extrusion for extrusion related commands.
This is the wrong place to discuss such topic any further and not related to this PR, where IMO the wording is pretty clear. If you want to further discuss this, open a post or feature request on https://klipper.discourse.group/ In Klipper such a requirement can usually easily be achieved via macros.
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html
There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.
Best regards, ~ Your friendly GitIssueBot
PS: I'm just an automated script, not a human being.
Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.
Best regards, ~ Your friendly GitIssueBot
PS: I'm just an automated script, not a human being.
I spent a good while scratching my head before looking at the source code.