Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
8.99k stars 5.18k forks source link

tmc5160: The maximum current of tmc5160 is determined by the sensor resistor #6381

Closed bigtreetech closed 7 months ago

bigtreetech commented 8 months ago

Signed-off-by: Alan.Ma from BigTreeTech tech@biqu3d.com

Some independent TMC5160 modules use high-efficiency MOSFETs and active heat sinks, so the current can be very high. The maximum current of TMC5160 is determined by the sampling resistance rather than a fixed 3A now.

thijstriemstra commented 8 months ago

I'm about to install some TMC5160 RGB and TMC5160 Pro v1.1 drivers and read only yesterday about a hard-coded current value in klipper code. Glad to see it's getting fixed!

KevinOConnor commented 7 months ago

Thanks. This was also raised in #6093. As with the comments in that PR, I'm concerned that the error check could become confusing to users. The main reason for the error check was to avoid some users entering in a milliamps (eg, 2000) where amps were desired (eg, 2). If 3 amps is not sufficient, can we just increase the maximum to 5 or 10 amps on tmc5160?

-Kevin

bigtreetech commented 7 months ago

If 3 amps is not sufficient, can we just increase the maximum to 5 or 10 amps on tmc5160?

It is definitely sufficient for stepper motors if it can be changed to 10A.

bigtreetech commented 7 months ago

close since https://github.com/Klipper3d/klipper/commit/bb4711c5d31e8159945f945c662e6668059a174f